-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize & apply standard formatting #325
Conversation
I pushed an additional commit. Some of the xml files still had tabs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I think it looks good.
Formatting seems to work and the the debug configurations / tasks also work.
If we notice any inconsistencies, we need to log new issues.
In general we should probably also add more documentation on how to run the theia cloud services locally, because e.g. the conversion webhook currently fails with java.nio.file.NoSuchFileException: /etc/webhook/certs/tls.crt
, since this path is hard-coded in the application.properties
But this is out of context for this PR
@jfaltermeier Thanks for the commit. For me both Theia IDE and VSCode do not change the formatting with tabs/whitespaces. So i can no longer reproduce that issue, so we should be good to go. More documentation regarding building locally definately makes sense, but i also agree that this should be done in a follow up 👍 |
Standardize the formatting for the use in VSCode.
Use the
java-formatter.xml
file together with thevscjava.vscode-java-pack
for Java formatting.Define prettier as the default formatter for most of the files.
Exceptions include:
ms-azuretools.vscode-docker
jebbs.plantuml
Also add all needed extensions to the recommendations.
Furthermore, transform all launch configs to tasks & debug configs.
Fixes #152