-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1176 Make ACL support optional #2359
iox-#1176 Make ACL support optional #2359
Conversation
046203d
to
e597773
Compare
e597773
to
aa51f20
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2359 +/- ##
=======================================
Coverage 78.32% 78.32%
=======================================
Files 439 440 +1
Lines 16162 16186 +24
Branches 2314 2314
=======================================
+ Hits 12659 12678 +19
- Misses 2652 2658 +6
+ Partials 851 850 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
275eb95
to
23fd506
Compare
23fd506
to
5b7b477
Compare
3ac6839
to
4d47226
Compare
…gnore lists ('Too Many Requests' Error)
bazel build --//:feature_acl=off //... | ||
``` | ||
|
||
Alternatively, you can persist this setting in a `.bazelrc` file to apply it automatically in all builds: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have in iceoryx2 a .bazelrc
file where we can add this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every project has a local .bazelrc
and the flag needs to be set in the respective user project
Notes for Reviewer
This PR makes the adds a compile time option to disable the ACL feature, even on supported OSes. This is useful in cases WSL (Windows Subsystem for Linux) which does not support ACLs but is identified as Linux.
The PR also adds the feature flag for bazel builds.
The feature is deactivated by using the same dummy implementation like it is done on platforms that do not support ACLs.
To reduce code duplication. The platform files for ACSs are also refactored with the new C++17 approach to conditionally include headers.
Furthermore, it fixes a cache issue with the Cirrus CI and add a link to the link checker ignore list due to repeatedly
Too Many Requests
errors in the CI.Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References