set multiarch container as default, disable... #177

nickboldt · 2021-02-24T19:36:50Z

What does this PR do?

set multiarch container as default, disable single-arch build

Change-Id: I3bf13419e30b11b520b4243dbb21b0cf6374547f
Signed-off-by: nickboldt [email protected]

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#19688 (moving to travis for multiarch)

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

nickboldt · 2021-02-24T19:38:47Z

Question:

should we move from

CACHE_IMAGE_FULL: docker.io/cheincubator/che-dashboard:cache

to new repo in existing quay che-incubator org?

CACHE_IMAGE_FULL: quay.io/che-incubator/che-dashboard:cache

That way we're not using as part of the build process, when we're ultimately pushing to Quay anyway.

github-actions · 2021-02-24T19:48:02Z

No changes to code coverage between the base branch and the head branch

che-bot · 2021-02-24T20:03:09Z

✅ E2E dashboard-next tests succeed 🎉

See Details

Jenkins job
logs and configs
Che dashboard-next image:docker.io/maxura/che-dashboard:177
Che server image: docker.io/maxura/che-server:177

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

github-actions · 2021-02-24T20:15:00Z

Docker image build succeeded: docker.io/maxura/che-server:che-dashboard-pull-177

sleshchenko

Nobody complained about removing multi-arch build, it's why it was made as optional due stability reasons.

I see potential value in multiarch build as default but github workflow should be reworked in the corresponding way where each (or some of) architectures are mandatory.
And then I don't see a value in keeping single arch image if Che Server and deployments depends on multiarch.

So, in general I'm OK with proposed multiarch by default, but if it won't be stable again, we will need to review it.

.github/workflows/ci-multiarch.yaml

.github/workflows/ci.yaml

che-bot · 2021-03-08T18:12:02Z

❌ E2E dashboard-next tests failed ❗

See Details

Jenkins job
test report
logs and configs
Che dashboard-next image:quay.io/crw_pr/che-dashboard:177
Che server image: quay.io/crw_pr/che-server:177

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

github-actions · 2021-03-08T18:18:03Z

No changes to code coverage between the base branch and the head branch

github-actions · 2021-03-08T18:43:30Z

Docker image build succeeded: docker.io/maxura/che-server:che-dashboard-pull-177

.github/workflows/ci-multiarch.yaml

dmytro-ndp · 2021-03-16T08:29:00Z

[dashboard-next-ci-test]

che-bot · 2021-03-16T08:59:46Z

❌ E2E dashboard-next tests failed ❗

See Details

Jenkins job
test report
logs and configs
Che dashboard-next image:quay.io/crw_pr/che-dashboard:177
Che server image: quay.io/crw_pr/che-server:177

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

dmytro-ndp · 2021-03-16T11:27:48Z

[dashboard-next-ci-test]

che-bot · 2021-03-16T11:50:49Z

✅ E2E dashboard-next tests succeed 🎉

See Details

Jenkins job
logs and configs
Che dashboard-next image:quay.io/crw_pr/che-dashboard:177
Che server image: quay.io/crw_pr/che-server:177

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Use comment "[dashboard-next-ci-test]" to rerun the 'dashboard-next' e2e tests

codecov · 2021-07-15T12:19:49Z

Codecov Report

Merging #177 (cf5d089) into main (ab26654) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #177   +/-   ##
=======================================
  Coverage   51.51%   51.51%           
=======================================
  Files         143      143           
  Lines        5536     5536           
  Branches      913      913           
=======================================
  Hits         2852     2852           
  Misses       2410     2410           
  Partials      274      274

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab26654...cf5d089. Read the comment docs.

sleshchenko · 2021-07-15T12:22:09Z

.github/workflows/next-build-multiarch.yml

@@ -106,5 +104,5 @@ jobs:
            echo "[!] The job 'build-images' didn't provide any outputs. Can't create the manifest list."
            exit 1;
          fi
-          docker manifest create ${{ env.IMAGE }}:multiarch-next $AMEND
-          docker manifest push ${{ env.IMAGE }}:multiarch-next
+          docker manifest create ${{ env.IMAGE }}:next $AMEND


Well, it also requires adapting PR check not to pass when multiarch build fails.
And it has a drawback... For some reason amd64 build takes 4-6 minutes, while other 35-45 minutes which is not critical but not pleasure when you add a rewording fix in the PR before merging.

github-actions · 2021-07-15T12:28:52Z

Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-177

github-actions · 2021-07-15T12:30:47Z

Docker image build succeeded: docker.io/maxura/che-dashboard:che-dashboard-pull-177

che-bot · 2021-07-15T12:32:17Z

✅ E2E dashboard tests succeed 🎉

See Details

Jenkins job
test report
logs and configs
Che dashboard image:quay.io/crw_pr/che-dashboard:177
Che server image: quay.io/crw_pr/che-server:177

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

che-bot · 2021-07-20T14:14:42Z

❌ E2E dashboard tests failed ❗

See Details

Jenkins job
test report
logs and configs
Che dashboard image:quay.io/crw_pr/che-dashboard:177
Che server image: quay.io/crw_pr/che-server:177

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

nickboldt requested review from akurinnoy and olexii4 as code owners February 24, 2021 19:36

nickboldt requested a review from ericwill February 24, 2021 19:39

sleshchenko reviewed Feb 25, 2021

View reviewed changes

.github/workflows/ci-multiarch.yaml Outdated Show resolved Hide resolved

.github/workflows/ci.yaml Outdated Show resolved Hide resolved

This was referenced Mar 1, 2021

Multiarch build support by docker buildx #119

Merged

Added multiarch support by docker buildx eclipse-che/che-devfile-registry#336

Merged

nickboldt force-pushed the multiarch-as-default branch from 7e808c2 to e9e10f7 Compare March 8, 2021 18:07

nickboldt requested a review from sleshchenko March 8, 2021 18:07

sleshchenko reviewed Mar 9, 2021

View reviewed changes

.github/workflows/ci-multiarch.yaml Outdated Show resolved Hide resolved

feat: do only multiarch build for next containers

de97a23

sleshchenko force-pushed the multiarch-as-default branch from e9e10f7 to de97a23 Compare July 15, 2021 12:13

fix: remove unused cache image env var

cf5d089

sleshchenko reviewed Jul 15, 2021

View reviewed changes

akurinnoy approved these changes Jul 15, 2021

View reviewed changes

sleshchenko merged commit c6aaaa1 into main Jul 15, 2021

sleshchenko deleted the multiarch-as-default branch July 15, 2021 13:14

che-bot added this to the 7.34 milestone Jul 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

set multiarch container as default, disable... #177

set multiarch container as default, disable... #177

nickboldt commented Feb 24, 2021 •

edited

Loading

nickboldt commented Feb 24, 2021

github-actions bot commented Feb 24, 2021

che-bot commented Feb 24, 2021

github-actions bot commented Feb 24, 2021

sleshchenko left a comment

che-bot commented Mar 8, 2021

github-actions bot commented Mar 8, 2021

github-actions bot commented Mar 8, 2021

dmytro-ndp commented Mar 16, 2021

che-bot commented Mar 16, 2021

dmytro-ndp commented Mar 16, 2021

che-bot commented Mar 16, 2021

codecov bot commented Jul 15, 2021 •

edited

Loading

sleshchenko Jul 15, 2021

github-actions bot commented Jul 15, 2021

github-actions bot commented Jul 15, 2021

che-bot commented Jul 15, 2021

che-bot commented Jul 20, 2021

set multiarch container as default, disable... #177

set multiarch container as default, disable... #177

Conversation

nickboldt commented Feb 24, 2021 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

nickboldt commented Feb 24, 2021

github-actions bot commented Feb 24, 2021

che-bot commented Feb 24, 2021

github-actions bot commented Feb 24, 2021

sleshchenko left a comment

Choose a reason for hiding this comment

che-bot commented Mar 8, 2021

github-actions bot commented Mar 8, 2021

github-actions bot commented Mar 8, 2021

dmytro-ndp commented Mar 16, 2021

che-bot commented Mar 16, 2021

dmytro-ndp commented Mar 16, 2021

che-bot commented Mar 16, 2021

codecov bot commented Jul 15, 2021 • edited Loading

Codecov Report

sleshchenko Jul 15, 2021

Choose a reason for hiding this comment

github-actions bot commented Jul 15, 2021

github-actions bot commented Jul 15, 2021

che-bot commented Jul 15, 2021

che-bot commented Jul 20, 2021

nickboldt commented Feb 24, 2021 •

edited

Loading

codecov bot commented Jul 15, 2021 •

edited

Loading