Add error handling for when the profile file yaml parsing fails #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anttimaki
requested changes
Nov 6, 2024
| try { | ||
| this.profileImportContent = await ProfileUtils.parseYamlToExportFormat(read); | ||
| } catch (e: unknown) { | ||
| if(e instanceof R2Error) { |
There was a problem hiding this comment.
Well probably want to catch all errors here, including the once possibly thrown by yaml.parse or any future additions to the helper function. So I would recommend skipping the if check and just using R2Error.fromThrownValue.
src/utils/ProfileUtils.ts
Outdated
| 'Ensure that the profile import file isn\'t corrupted.' | ||
| ) | ||
| } | ||
| if (!parsedYaml.profileName || typeof parsedYaml.profileName !== 'string') { |
There was a problem hiding this comment.
Nitpick: typeof parsedYaml.profileName !== 'string' would suffice here since undefined is not a string.´?
src/utils/ProfileUtils.ts
Outdated
| 'Ensure that the profile import file isn\'t corrupted.' | ||
| ) | ||
| } | ||
| if (!parsedYaml.mods || typeof parsedYaml.mods !== 'object') { |
There was a problem hiding this comment.
Looking at old L130/new L151 it looks like we're expecting an array, and while object might be an array, it might not. Using if(!Array.isArray(parsedYaml.mods) { would be more accurate, shorter, and make the intent clearer to the reader.
VilppeRiskidev
force-pushed
the
handle-corrupted-profile-import-errors
branch
from
4b6392e
to
61d1ce4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.