Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow : in select strings #551

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Allow : in select strings #551

merged 5 commits into from
Oct 10, 2024

Conversation

strengejacke
Copy link
Member

No description provided.

etiennebacher
etiennebacher approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, just a couple of comments + NEWS item to add

R/select_nse.R Show resolved Hide resolved
tests/testthat/test-select_nse.R Show resolved Hide resolved
@etiennebacher etiennebacher changed the title Allow : in select strings Allow : in select strings Oct 10, 2024
@strengejacke strengejacke merged commit 9dff2ae into main Oct 10, 2024
22 checks passed
@strengejacke strengejacke deleted the select_colon_strings branch October 10, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebacher etiennebacher etiennebacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strengejacke @etiennebacher