Put vignettes in .Rbuildignore
#534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strengejacke
approved these changes
Aug 24, 2024
|
@strengejacke is it fine if I make a new release now to fix those errors on macOS? |
|
Yes. We could also merge #533 before, wdyt? |
|
It seems the discussion in #530 is not finished and I'd like jmgirard to review the PR if possible, I don't think I can say anything meaningful on the implementation in itself |
|
His feedback was "This looks correct". :-) |
I think you can plan your release w/o waiting for #535, that PR's not urgent. |
|
Ok I'll make the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #527