Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rowmean_n() #445

Merged
merged 13 commits into from
Aug 10, 2023
Merged

Implement rowmean_n() #445

merged 13 commits into from
Aug 10, 2023

Conversation

strengejacke
Copy link
Member

No description provided.

@DominiqueMakowski
Copy link
Member

should we name it "rowmean_n" ?

@codecov

This comment was marked as outdated.

Sign in to view
@strengejacke
Copy link
Member Author

should we name it "rowmean_n" ?

mean_n() was in reference to SPSS' MEAN.n, but we can name it rowmean_n(), or add an alias?

@DominiqueMakowski
Copy link
Member

too much aliases can be confusing, I'd say go with rowmean as it's more R-like (and I don't think we need to be consistent with SPSS naming schemes ^^)

etiennebacher
etiennebacher requested changes Aug 10, 2023
View reviewed changes
R/rowmean_n.R Outdated Show resolved Hide resolved
R/rowmean_n.R Outdated Show resolved Hide resolved
R/rowmean_n.R Outdated Show resolved Hide resolved
@etiennebacher etiennebacher changed the title draft mean_n() Implement rowmean_n() Aug 10, 2023
@etiennebacher etiennebacher merged commit 6e3182c into main Aug 10, 2023
26 checks passed
@etiennebacher etiennebacher deleted the mean_n branch August 10, 2023 16:46
@strengejacke
Copy link
Member Author

cool, thanks!

@etiennebacher
Copy link
Member

thank you ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebacher etiennebacher etiennebacher approved these changes

@IndrajeetPatil IndrajeetPatil Awaiting requested review from IndrajeetPatil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strengejacke @DominiqueMakowski @etiennebacher