Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WoofedCRM Template to Easy Panel template library. #593

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zzedgat2012
Copy link

No description provided.

Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for easypanel-templates ready!

Name Link
🔨 Latest commit 38fcd9e
🔍 Latest deploy log https://app.netlify.com/sites/easypanel-templates/deploys/6730bfe3c8bd5100087d0029
😎 Deploy Preview https://deploy-preview-593--easypanel-templates.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Ahson-Shaikh
Copy link

Hey - Try providing images in the meta.yaml so people can have a choice to change it if needed at the runtime. Also please avoid using latest tags, as new images can have different set of configurations. Thanks.

@zzedgat2012
Copy link
Author

@Ahson-Shaikh, okay! Thx for the feedback!

@zzedgat2012
Copy link
Author

This block of code here in the build-docs.ts was prevented me to build the project. I remove it and the project builds with no errors:

    if (meta?.contributors?.length) {
      lines.push("## Contributors", "");
      meta.contributors.forEach((entry) => {
        lines.push(`- [${entry.name}](${entry.url})`);
      });
      lines.push("");
    }

@Ahson-Shaikh
Copy link

@zzedgat2012 Template looks good and works good. But there are just little implementations.

1.  // Good Job service
  services.push({
    type: "app",
    data: {
      serviceName: "woofed-good_job",
      source: {
        type: "image",

Change to woofed-goodjob

  1. Use ${input.appServiceName}-sidequik or goodjob
  2. Can you provide an option to let people decide the timezone?

@zzedgat2012
Copy link
Author

Sure, I'll be making those changes.

{
type: "volume",
name: "woofedcrm_data",
mountPath: "/app",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zzedgat2012 do you want all 3 services to share the same volume?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, essentially the sidekiq and goojob are all the same container running different services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants