Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20706] Bugfix in DDSBlackboxTestsDataReader test #4720

Merged
merged 1 commit into from
Apr 24, 2024
Merged

[20706] Bugfix in DDSBlackboxTestsDataReader test #4720

merged 1 commit into from
Apr 24, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Apr 23, 2024 •
edited by MiguelCompany
Loading

Description

This PR forwards a test fix from #4708 regarding the StackAllocatedSequence.

Note, I checked with master and OK, but the reviewer is encouraged to ask manually for a specific ci despite I added the skip-ci. I am leaving the label though for now.

@Mergifyio backport 2.13.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A Check CI results: changes do not issue any warning.
  • N/A Check CI results: failing tests are unrelated with the changes.
    • Affected test was run locally in Windows and Ubuntu.

@Mario-DL Mario-DL added the skip-ci Automatically pass CI label Apr 23, 2024
@Mario-DL Mario-DL added this to the v2.14.1 milestone Apr 23, 2024
@MiguelCompany MiguelCompany merged commit 48aa538 into master Apr 24, 2024
3 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/20706 branch April 24, 2024 05:48
@Mario-DL
Copy link
Member Author

@Mergifyio backport 2.13.x 2.10.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 24, 2024 •
edited
Loading

backport 2.13.x 2.10.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 24, 2024
@Mario-DL @mergify
Bugfix in DDSBlackboxTestsDataReader test (#4720)
a7efcc8 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 48aa538)

# Conflicts:
#	test/blackbox/common/DDSBlackboxTestsDataReader.cpp
mergify bot pushed a commit that referenced this pull request Apr 24, 2024
@Mario-DL @mergify
Bugfix in DDSBlackboxTestsDataReader test (#4720)
64ab2e7 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 48aa538)
This was referenced Apr 24, 2024
Closed
Merged
MiguelCompany pushed a commit that referenced this pull request Apr 24, 2024
@mergify @Mario-DL
Bugfix in DDSBlackboxTestsDataReader test (#4720) (#4722)
e546c70 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit 48aa538)

Co-authored-by: Mario Domínguez López <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
skip-ci Automatically pass CI
Projects
None yet
Milestone
v2.14.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @MiguelCompany