Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21508] Check fastcdr major version in FastDDSGenCodeTester source file #964

Merged
merged 1 commit into from
Nov 27, 2024
Merged

[21508] Check fastcdr major version in FastDDSGenCodeTester source file #964

merged 1 commit into from
Nov 27, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Nov 26, 2024 •
edited by MiguelCompany
Loading

Description

This PR adds a check fastcdr major version in FastDDSGenCodeTester source file. This should prevent that compilation against fastcdr 1.0 from failing.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • N/A Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@Mario-DL Mario-DL added this to the v2.14.5 milestone Nov 27, 2024
@Mario-DL Mario-DL changed the title [21508] Add fastcdr v1 guards whrn compiling against fastcdr v1 [21508] Check fastcdr major version in FastDDSGenCodeTester source file Nov 27, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima November 27, 2024 07:47
@Mario-DL Mario-DL marked this pull request as ready for review November 27, 2024 07:47
@Mario-DL Mario-DL merged commit 2601f88 into 2.14.x Nov 27, 2024
4 checks passed
@Mario-DL Mario-DL deleted the fix/21508 branch November 27, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v2.14.4 - Frozen ❄️
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @MiguelCompany