Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spinner and sidebar toggle #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

d-rk
Copy link
Contributor

@d-rk d-rk commented Jan 24, 2022

Hi

I hope you don't mind another PR from me 😰

This PR introduces the following:

  • the sidebar is hidden by default (needed for the spinner)
  • while search for an engine is running a spinner is shown
  • a click on the sidebar first focuses the engine results. a second click collapses the engine results and a third one expands them again
  • links in search results are opened on a new page

hiddenEngines={localData.hiddenEngines || []}
onToggle={engineId => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the onToggle method here is the same like below in <Results. this needs to be refactored, but I gonna need help for this.

@artnc
Copy link
Member

artnc commented Jan 24, 2022

Could you please post some screenshots? I'm having trouble getting the spinner to appear 🤔

Also I'd prefer to follow standard UI patterns (seen in other search websites like Google) by letting the user decide whether they want to open result links in new tabs (e.g. via middle click or ctrl+click) rather than deciding for them

@d-rk
Copy link
Contributor Author

d-rk commented Jan 25, 2022

Could you please post some screenshots? I'm having trouble getting the spinner to appear 🤔

I tested it again in Firefox and Chrome. Works on my machine :)
spinner

Also I'd prefer to follow standard UI patterns (seen in other search websites like Google) by letting the user decide whether they want to open result links in new tabs (e.g. via middle click or ctrl+click) rather than deciding for them

Thats a valid point. I reverted the changed link open behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants