refactor: use build tags to disable, instead of to enable a feature #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
force-pushed
the
refactor/build-tags
branch
from
26a9594
to
76a95ab
Compare
|
Fetching the watcher header is probably a good idea. Would it make senso to add a check in the pipeline that will make the watcher installation fail if a new header is available? |
|
Also msan fails again with the watcher. We can either disable tests or try our luck at a memory sanitized stdc++. I found this Docker image with instructions I haven't tried yet: https://github.com/awslabs/amazon-kinesis-video-streams-webrtc-sdk-c/blob/master/.github/msan-tester.Dockerfile |
dunglas
force-pushed
the
refactor/build-tags
branch
from
76a95ab
to
965f632
Compare
withinboredom
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a way to fetch the latest C header provided by watcher using
go generate.