Fix a few issues to make the main loop work #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vegarsti
commented
Jun 7, 2024
•
vegarsti
commented
- Removes the retryable http client for now. It's getting stuck retrying forever if there's an error (at least an internal error) and seems to ignore context cancel
- Remove extra newlines in the payload
- Fix trace request (we were adding an extra layer of string escaping)
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
vegarsti
added a commit
that referenced
this pull request
Jun 7, 2024
As mentioned in #10, we were not seeing context propagation work. Turns out we just needed to create the request with the context correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.