Fix: modal content getting covered by Drawer Vaul #1612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1609
Issue Description
The common
Modal Component
built on top of Drawer from Vaul ships with some default css which is introducing an overlay with an ::after attribute on top of the modal content on smaller devices. See the below imagesNow if you take a good look at
data-attributes
the css activates on two condition whendirection
isbottom
and nocustom-container
is not passed, which is our case.Trials
200%
height is there so the layer is scrollable without any content over there. (x)Modal Component
but got no luck. (x)Fix
The only way to grab the element and set its height properly was to use
css
and as every component is sharing the same modal therefore it is a global issue so added the css in global.css file.After the fix
Verified that it works on smaller devices as well as tabs and laptops. Find the screen shots below