Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyQt vs. PySide QFontDialog.getFont difference #36

Open
wants to merge 1 commit into
base: python3
Choose a base branch
from

Conversation

mdsandell
Copy link
Contributor

This fixes an issue with dragging tabs in PySide2 and python3 on Mac. Test by click-dragging any open tab. Drag/drop the tab on top of another tab in a second window to fully test the fix.

Traceback (most recent call last):
  File "/Users/Mark/.local/lib/python3.10/site-packages/usdmanager-0.15.0-py3.10.egg/usdmanager/__init__.py", line 3865, in mouseMoveEvent
    mimeData.setData("action", "moveTab")
TypeError: 'PySide2.QtCore.QMimeData.setData' called with wrong argument types:
  PySide2.QtCore.QMimeData.setData(str, str)
Supported signatures:
  PySide2.QtCore.QMimeData.setData(str, PySide2.QtCore.QByteArray)

This also fixes a bug with font selection in the Preferences dialog in PySide1/2. This appears to be a difference between PyQt and PySide, returning font and ok in a different order. Test by going to Preferences and changing the font, watching for any terminal errors.

Traceback (most recent call last):
  File "/Users/Mark/.local/lib/python3.10/site-packages/usdmanager-0.15.0-py3.10.egg/usdmanager/preferences_dialog.py", line 382, in selectFont
    self.updateFontLabel()
  File "/Users/Mark/.local/lib/python3.10/site-packages/usdmanager-0.15.0-py3.10.egg/usdmanager/preferences_dialog.py", line 387, in updateFontLabel
    bold = "Bold " if self.docFont.bold() else ""
AttributeError: 'bool' object has no attribute 'bold'

python3 QMimeData requires QByteArray, not str

Signed-off-by: Mark Sandell <[email protected]>

s
@tracypriest
Copy link
Collaborator

@mdsandell Thanks for the update! It looks like we don't have a CLA for you. Could you sign the contributor agreement and email that to [email protected]?

Thanks a bunch!

@mdsandell
Copy link
Contributor Author

mdsandell commented Jul 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants