feat(dracut-initramfs-restore.sh): get compression method from image #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create functions with common code as a previous step to use them in other parts. In particular: - `get_machine_id` - `get_default_initramfs_image [<kernel_version>]` - `has_early_microcode <initramfs_image>` - `get_decompression_command <initramfs_image_header>`
Instead of trying every possible compression method until the right one is found, parse the header of the initramfs image to get the right one and use it without hiding possible decompression errors, using the same logic that is implemented in `lsinitrd.sh`.
aafeijoo-suse
force-pushed
the
dracut-initramfs-restore-rewrite-feat
branch
from
5a01cd0
to
4c8320b
Compare
|
@tblume JFYI, this is what we discussed internally this week. |
aafeijoo-suse
force-pushed
the
dracut-initramfs-restore-rewrite-feat
branch
from
48c298a
to
adbafed
Compare
aafeijoo-suse
force-pushed
the
dracut-initramfs-restore-rewrite-feat
branch
from
adbafed
to
b063309
Compare
…laceholder Implement and use a new `get_dollar_boot` function to get the `$BOOT` partition placeholder, as defined in the Boot Loader Specification [1]. If `bootctl` is available, use it to support a possible XBOOTLDR partition, otherwise, check only the ESP, as before. [1] https://uapi-group.org/specifications/specs/boot_loader_specification
Use the new functions `get_dollar_boot`, `get_machine_id` and `get_default_initramfs_image` to get the `outfile` path. Fixes dracutdevs#1995
aafeijoo-suse
force-pushed
the
dracut-initramfs-restore-rewrite-feat
branch
from
b063309
to
43469bf
Compare
Since v6.8-rc1 [1], when the kernel was booted with an initrd and the `retain_initrd` option is set on the kernel command line, /sys/firmware/initrd contains the contents of the initrd that the kernel was booted with. Therefore, there is no need to guess the path of the initrd for `lsinitrd` and `dracut-initramfs-restore` if this sysfs file exists on the running system. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2678fd2fe9ee2c569e9cb6b17e786bc8f0753538
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
|
This issue is being marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. If this is still an issue in the latest release of Dracut and you would like to keep it open please comment on this issue within the next 7 days. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of trying every possible compression method until the right one is found, parse the header of the initramfs image to get the right one and use it without hiding possible decompression errors, using the same logic that is implemented in
lsinitrd.sh.For that, refactor
lsinitrd.shmoving common code todracut-functions.sh. In particular:get_machine_idget_default_initramfs_image [<kernel_version>]has_early_microcode <initramfs_image>get_decompression_command <initramfs_image_header>Also, added a new
get_dollar_bootfunction to get the$BOOTpartition placeholder, as defined in the Boot Loader Specification. Ifbootctlis available, use it to support a possible XBOOTLDR partition, otherwise, check only the ESP, as before.Also refactored
dracut.shusing these new functions to get theoutfilepath.Checklist