Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tasks to max project across channels or z-slices #8

Merged
merged 20 commits into from
Sep 19, 2023
Merged

Conversation

tddough98
Copy link
Collaborator

  • Add two tasks MaxProjectFiducial and MaxProjectBits
    • MaxProjectFiducial allows using all z-slices of fiducial beads when available instead of having to select a single z-slice where some fiducial beads may be out of focus.
    • MaxProjectBits can simulate a polyT channel from all the available bits for use in WatershedSegment
  • Update WatershedSegment and FiducialCorrelationWarp to access max projected images from these tasks when they are included in downstream tasks' parameters.

Mixed in are a handful of miscellaneous improvements like

  • Move SimpleTasks into the tests folder as they're only used in tests and not part of the public API
  • add docstrings and type annotations to modified functions
  • Drop a few unused or redundant functions like get_image_dimensions and get_microns_per_pixel
  • Renames some verbose variable names such as frame_number --> frame

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 89.49% and project coverage change: +0.14% 🎉

Comparison is base (eb09577) 87.76% compared to head (500630e) 87.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   87.76%   87.90%   +0.14%     
==========================================
  Files          57       59       +2     
  Lines        5060     5186     +126     
==========================================
+ Hits         4441     4559     +118     
- Misses        619      627       +8     
Files Changed Coverage Δ
merlin/analysis/generatemosaic.py 71.73% <0.00%> (ø)
merlin/analysis/optimize.py 75.27% <ø> (ø)
merlin/merlin.py 75.49% <ø> (ø)
test/simple_tasks.py 78.33% <ø> (ø)
test/test_snakemake.py 100.00% <ø> (ø)
merlin/data/dataorganization.py 84.56% <57.14%> (-1.46%) ⬇️
merlin/analysis/globalalign.py 68.62% <60.00%> (ø)
merlin/analysis/warp.py 83.33% <76.19%> (+1.14%) ⬆️
merlin/util/imagereader.py 66.48% <78.94%> (+0.71%) ⬆️
merlin/analysis/maxproject.py 90.47% <90.47%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tddough98 tddough98 merged commit 9357a8c into main Sep 19, 2023
5 checks passed
@tddough98 tddough98 deleted the fix-watershed branch September 19, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant