Disable offending H/3 op causing server errors (#58541)

Co-authored-by: ManickaP <[email protected]>
dotnet · Sep 7, 2021 · a99190c · a99190c
1 parent c300b09
commit a99190c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 12 deletions.
diff --git a/eng/pipelines/libraries/stress/http.yml b/eng/pipelines/libraries/stress/http.yml
@@ -50,7 +50,7 @@ jobs:
 
   - bash: |
       cd '$(httpStressProject)'
-      export HTTPSTRESS_CLIENT_ARGS="$HTTPSTRESS_CLIENT_ARGS -http 3.0"
+      export HTTPSTRESS_CLIENT_ARGS="$HTTPSTRESS_CLIENT_ARGS -http 3.0 -xops 10"
       export HTTPSTRESS_SERVER_ARGS="$HTTPSTRESS_SERVER_ARGS -http 3.0"
       docker-compose up --abort-on-container-exit --no-color
     displayName: Run HttpStress - HTTP 3.0

diff --git a/src/libraries/System.Net.Http/tests/StressTests/HttpStress/ClientOperations.cs b/src/libraries/System.Net.Http/tests/StressTests/HttpStress/ClientOperations.cs
@@ -508,12 +508,6 @@ public static (string name, Func<RequestContext, Task> operation)[] Operations =
 
         private static void ValidateStatusCode(HttpResponseMessage m, HttpStatusCode expectedStatus = HttpStatusCode.OK)
         {
-            // [ActiveIssue("https://github.com/dotnet/runtime/issues/55261")]
-            if (m.StatusCode == HttpStatusCode.InternalServerError)
-            {
-                throw new Exception("IGNORE");
-            }
-
             if (m.StatusCode != expectedStatus)
             {
                 throw new Exception($"Expected status code {expectedStatus}, got {m.StatusCode}");

diff --git a/src/libraries/System.Net.Http/tests/StressTests/HttpStress/StressClient.cs b/src/libraries/System.Net.Http/tests/StressTests/HttpStress/StressClient.cs
@@ -209,11 +209,6 @@ async Task RunWorker(int taskNum)
                     {
                         _aggregator.RecordCancellation(opIndex, stopwatch.Elapsed);
                     }
-                    catch (Exception e) when (e.Message == "IGNORE")
-                    {
-                        // [ActiveIssue("https://github.com/dotnet/runtime/issues/55261")]
-                        // See ClientOperations.ValidateStatusCode
-                    }
                     catch (Exception e)
                     {
                         _aggregator.RecordFailure(e, opIndex, stopwatch.Elapsed, requestContext.IsCancellationRequested, taskNum: taskNum, iteration: i);