Use some StringSyntax attributes #10813
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reated directly (dotnet#10678) Call method that tells Windows to allow VT-100 output processing whenever the TerminalLogger is instantiated, rather than only in the MSBuild CLI entrypoint `xmake.cs`. Fixes dotnet#10579.
Part of dotnet#10665 Final branding for VS17.12.
…: Build ID 10325489 (dotnet#10748)
…otnet#10745) * Allow fast-abort of submissions even after EndBuild initiated * Bump version * Add test verifying the proper build abort on CancelAllSubmissions swapped * Bump version * bump version to 17.12.3 --------- Co-authored-by: YuliiaKovalova <[email protected]>
rainersigwald
force-pushed
the
stringsyntax
branch
from
081f12f
to
bd94f1f
Compare
But don't use it anywhere yet.
Includes some nullability adjustments to work with the new paradigm.
This doesn't appear to do anything today, alas.
Mostly customer-facing here in public classes.
The 9.0.100-rc.2 SDK caught these tests with (in this case intentionally) malformed format strings.
…s17.12-to-main
* Update dependencies from https://github.com/dotnet/arcade build 20241016.2 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24466.2 -> To Version 9.0.0-beta.24516.2 * Bump up version prefix * Remove unavailable BuildXL feed * Bump up dotnet version used in bootstrap along with dotnet bumped in global.json --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Gang Wang <[email protected]>
JanKrivanek
approved these changes
Oct 20, 2024
…on ID 9434: Build ID 10415672 (dotnet#10849)
maridematte
approved these changes
Oct 23, 2024
rainersigwald
force-pushed
the
stringsyntax
branch
from
f0ab1cf
to
34460a4
Compare
…taserrors-from-worker-nodes Always respect warning-as-error properties
I happened by this code and was sad at how allocatey it was. We don't care much in unit tests but I was moved to fix it.
Fixes dotnet#10956 by moving to a thread-safe dictionary. These locks shouldn't ever really contend, because evaluation is single- threaded and the events should generally come in order for a single project, so I suspect locking is cheaper than switching the values to a ConcurrentHashSet.
* fix IDE0002 in XMakeElements.cs * - * Update src/Shared/XMakeElements.cs * Update src/Shared/XMakeElements.cs * Update src/Shared/XMakeElements.cs Co-authored-by: Rainer Sigwald <[email protected]> * readonly array --------- Co-authored-by: Rainer Sigwald <[email protected]>
…otnet#10914) Fixes dotnet#10522 Context Second PR for that issue. This PR covers the cases in a Custom Check where there is an exception while registering actions, and when running said actions. Since actions are individuals, we do not deregister the whole analyzer when one fails. It has been decided to expose these errors are warnings instead to not break the build where they show up. Changes Made Added some try catch statements so errors do not break builds. Messages have been added to each case for more detail as we do not preserve anything else from the exception.
Fixes dotnet#10333 Context Change the MSB4019 error message (ImportedProjectNotFound) to include the unevaluated value of the Import element's Project attribute. Changes Made Changed the error message to use the wording proposed in the issue. Added the unevaluated value of the Project attribute when the error message is used. Added a unit test for the MSB4019 error.
…6.13.0.60 (dotnet#10964) This pull request updates the following dependencies From https://github.com/nuget/nuget.client Subscription: 3fe128a9-5a85-4aba-f7ba-08da008becb5 Build: 6.13.0.60 Date Produced: November 7, 2024 11:19:20 PM UTC Commit: 4f24d6d51798557a1c54b4aad71389a08af94cfd Branch: dev Updates: NuGet.Build.Tasks: from 6.13.0-preview.1.52 to 6.13.0-preview.1.60
…: Build ID 10541588 (dotnet#10970)
This test failed on my machine and it wasn't clear why, so I'm updating its assertions and style.
…: Build ID 10543954 (dotnet#10971) * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 10543380 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 10543954
…: Build ID 10549837 (dotnet#10974)
…111.1 (dotnet#10965) From https://github.com/dotnet/roslyn Subscription: 8a4332aa-2543-4c51-b941-e73f31e22328 Build: 20241111.1 Date Produced: November 11, 2024 12:50:12 PM UTC Commit: 543cb4568f28b0d2f2cfecdf2d56365b9252e848 Branch: refs/heads/main Updates: Microsoft.SourceBuild.Intermediate.roslyn: from 4.13.0-2.24557.8 to 4.13.0-2.24561.1 Microsoft.Net.Compilers.Toolset: from 4.13.0-2.24557.8 to 4.13.0-2.24561.1
…: Build ID 10555429 (dotnet#10980)
I ran across this while looking at a unit test, hovered over it, and was annoyed that I didn't get the description.
…: Build ID 10565507 (dotnet#10981)
* Add message codes for BuildCheck suggestion diags * Fix writing and add targeted test
* Add EvaluatedItemCheckData * Fix build
…6.13.0.62 (dotnet#10987) NuGet.Build.Tasks From Version 6.13.0-preview.1.60 -> To Version 6.13.0-preview.1.62 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…112.13 (dotnet#10988) Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24516.2 -> To Version 9.0.0-beta.24562.13 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…#10949) Fixes dotnet#10907 ### Context The `UseUtf8Encoding` property of the `Exec` task and other `ToolTask` derived tasks should accept `true` and equivalent to `always`. ### Changes Made `ToolTask` doesn't validate or interpret the `UseUtf8Encoding` property. The value of the property is passed to and interpreted by `EncodingUtilities.BatchFileEncoding()`. `EncodingUtilities` was modified to add a const string for `TRUE` and the `BatchFileEncoding()` method was modified to handle `TRUE` and `ALWAYS` the same. ### Testing Created a unit test that compares the returns for `ALWAYS` and `TRUE`, confirmed that the unit test failed, modified the code, and confirmed the unit test passes. Tested on Windows. ### Notes On non-Windows platforms the `UseUtf8Encoding` property has no effect.
* No helplink for custom check diags * Add help link customization * Fix typo
…ence-packages build 20241118.3 (dotnet#10997) Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.24517.1 -> To Version 9.0.0-alpha.1.24568.3 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Fill `StringSyntax` in for some of our APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fill
StringSyntaxin for some of our APIs.This is on much shakier ground than my other PR for new language features:
msbuild/eng/Common.globalconfig
Line 411 in 030946c
On balance I think I still want it but if someone disagrees we can close it.