[iOS] Fixed the RemainingItemsThresholdReachedCommand not firing issue in CollectionView #26067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Vignesh-SF3580! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
added
platform/iOS 🍎
area-controls-collectionview
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Nov 25, 2024
|
|
||
| [Test] | ||
| [Category(UITestCategories.CollectionView)] | ||
| public void RemainingItemsThresholdReachedCommandFired() |
There was a problem hiding this comment.
The test is failing on iOS:
Assert.That(label.GetText(), Is.EqualTo("Command Fired!"))
Expected string length 14 but was 9. Strings differ at index 0.
Expected: "Command Fired!"
But was: "Not fired"
There was a problem hiding this comment.
I've updated the code based on your feedback. Could you please review it and let me know if there are any further concerns
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Detail
The RemainingItemsThresholdReachedCommand is not triggered as expected on macOS and iOS platforms.
Root Cause
On macOS and iOS, the index of the items was only being updated based on the currently visible items. During scrolling, the index was not recalculated correctly, which caused the command to fail when the remaining items threshold was reached.
Description of Change
Updated the logic to ensure the index of items is recalculated accurately during scrolling. This change ensures that the RemainingItemsThresholdReachedCommand is triggered correctly when the threshold condition is met on macOS and iOS.
Tested the behaviour in the following platforms
Issues Fixed
Fixes #25889
Screenshots
Before.Fix.mov
After.Fix.mov