-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Source-build: Allow setting KnownAppHostPack and KnownRuntimePack #46735
[release/6.0] Source-build: Allow setting KnownAppHostPack and KnownRuntimePack #46735
Conversation
Thanks for your PR, @ayakael. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Hi @ayakael. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me but I don't think the branches are open. @mmitche, @vseanreesermsft❔
This won't succeed for a while. Is the fix urgent❔ |
Not at all. We already deploy this fix in the Alpine Linux dotnet6 package so the runtime graph gets automatically updated on new releases. I'm upstreaming this as a courtesy. |
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
##Source-build: Allow setting KnownAppHostPack and KnownRuntimePack
Description
This should've been in #44752, which was backport of #43937. Without this, we run into unrecognized RID issues in source-build application.
Customer impact
Will be able to build aspnetcore with RIDs that were automatically added in the runtime graph when building with source-build.
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
Only activates when
PortableBuild=false
. As it defaults totrue
, this change should not affect any other customers than distro maintainers.Verification
Packaging changes reviewed?