Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Add more crossgen2 dependencies #37410

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Oct 8, 2021

Add more crossgen2 dependencies (#37374)

  • Fix build on an arm64 machine
    • Building ASP.NET Core on an arm64 machine leads to a dependency error
      because crossgen2 is not listed in eng/Dependencies.props.
  • Add all arm/arm64 variants
  • Add all win variants for crossgen2

Co-authored-by: Doug Bunting [email protected]

- backport of dotnet#37374, `cherry-pick` of 64f0642

Add more `crossgen2` dependencies (dotnet#37374)

  * Fix build on an arm64 machine
    * Building ASP.NET Core on an arm64 machine leads to a dependency error
      because `crossgen2` is not listed in eng/Dependencies.props.
  * Add all arm/arm64 variants
  * Add all win variants for `crossgen2`

  Co-authored-by: Doug Bunting <[email protected]>
@dougbu dougbu added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Oct 8, 2021
@dougbu dougbu requested a review from a team October 8, 2021 21:51
@dougbu
Copy link
Member Author

dougbu commented Oct 8, 2021

tell-mode seems appropriate since this change won't impact our AzDO builds. Do need approval though (because our backport action didn't work)

@dougbu dougbu enabled auto-merge (squash) October 8, 2021 22:54
@dougbu dougbu merged commit e0a5a34 into dotnet:release/6.0 Oct 8, 2021
@ghost ghost added this to the 6.0.0 milestone Oct 8, 2021
@dougbu dougbu deleted the dougbu/extend.crossgen2/6.0 branch October 8, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants