[release/6.0-rc1] Don't cache CanReuse value #35676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
BrennanConroy,
halter73 and
Tratcher
as code owners
ghost
added
the
JamesNK
approved these changes
Aug 24, 2021
adityamandaleeka
approved these changes
Aug 25, 2021
|
@sebastienros Good to merge? |
|
@mmitche yes please |
captainsafia
added a commit
that referenced
this pull request
Aug 26, 2021
* Update dependencies from https://github.com/dotnet/efcore build 20210824.20 (#35675) [release/6.0-rc1] Update dependencies from dotnet/efcore * [release/6.0-rc1] Update dependencies from dotnet/efcore dotnet/runtime (#35677) [release/6.0-rc1] Update dependencies from dotnet/efcore dotnet/runtime * Update dependencies from https://github.com/dotnet/efcore build 20210824.28 (#35681) [release/6.0-rc1] Update dependencies from dotnet/efcore * [release/6.0-rc1] Don't cache CanReuse value (#35676) * Don't cache CanReuse value * Comment on when to use CanReuse Co-authored-by: Sebastien Ros <[email protected]> * Fix key comparison for more than 10 elements in AdaptiveCapacityDictionary (#35705) Co-authored-by: Brennan <[email protected]> * [release/6.0-rc1] [SPA] Ensure spawned NPM processes are terminated when the dotnet process is ungracefully terminated (#35701) * Adds a script to terminate the spawned NPM processes automatically when the host dotnet process is ungracefully terminated. Co-authored-by: Javier Calvarro Nelson <[email protected]> * Update dependencies from https://github.com/dotnet/runtime build 20210825.7 (#35726) [release/6.0-rc1] Update dependencies from dotnet/runtime * Move IResultsExtension to M.A.Http namespace (#35717) Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sebastien Ros <[email protected]> Co-authored-by: Brennan <[email protected]> Co-authored-by: Javier Calvarro Nelson <[email protected]> Co-authored-by: Safia Abdalla <[email protected]>
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34768
Backport of #35575 to release/6.0-rc1
/cc @sebastienros
Customer Impact
Under high POST requests load there is a race condition which can result in an Internal Server exception reported to an aborting client connection. This was discovered by the YARP team while doing stress testing with H2 traffic.
Testing
Manual.
The stress tool used by the YARP/runtime team was used to verify the issue doesn't occur after the fix.
Risk
Low.
The fix is preventing an object from being pooled as aggressively as before.