Update product-builds-dnceng-pipeline-secrets.yaml #15278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
dougbu
reviewed
Nov 26, 2024
| @@ -22,6 +22,7 @@ secrets: | |||
|
|
|||
| # public_repo scopes (classic token) | |||
| # Used in dotnet-comment-bot-service-connection in dnceng-public and DevDiv | |||
| # When this PAT is updated, the seervice connection should be updated. | |||
There was a problem hiding this comment.
@garath do we have a secret-manager setting that would cause a warning or something more visible❓ specifically, something that would tell FR or similar to do the necessary manual part❓
There was a problem hiding this comment.
Unfortunately, no, there is nothing right now that would cause extra info to be emitted.
There was a problem hiding this comment.
and, similarly, we can't automatically update at least one of the two dotnet-comment-bot-service-connection values❓
I guess the other option would be to revive https://dev.azure.com/dnceng/internal/_wiki/wikis/DNCEng%20Services%20Wiki/1249/PAT-recycling w/ information about service connections that must be handled manually still. would that help here❓
dougbu
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To double check: