Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] produce multiple "flavors" of runtime packs #9538

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

jonathanpeppers
Copy link
Member

Right now our runtime packs are all identical for each .NET "runtime", but we want to be able to produce different packs, such as:

Microsoft.Android.Runtime.Mono.35.android-arm
Microsoft.Android.Runtime.Mono.35.android-arm64
Microsoft.Android.Runtime.Mono.35.android-x86
Microsoft.Android.Runtime.Mono.35.android-x64
Microsoft.Android.Runtime.NativeAOT.35.android-arm
Microsoft.Android.Runtime.NativeAOT.35.android-arm64
Microsoft.Android.Runtime.NativeAOT.35.android-x86
Microsoft.Android.Runtime.NativeAOT.35.android-x64

Currently, the contents of all these packs are identical, but this is an initial step to build multiple packs.

The plan is for the workload to only install the "Mono" packs, and the "NativeAOT" packs can be restored via NuGet.

Right now our runtime packs are all identical for each .NET "runtime",
but we want to be able to produce different packs, such as:

    Microsoft.Android.Runtime.Mono.35.android-arm
    Microsoft.Android.Runtime.Mono.35.android-arm64
    Microsoft.Android.Runtime.Mono.35.android-x86
    Microsoft.Android.Runtime.Mono.35.android-x64
    Microsoft.Android.Runtime.NativeAOT.35.android-arm
    Microsoft.Android.Runtime.NativeAOT.35.android-arm64
    Microsoft.Android.Runtime.NativeAOT.35.android-x86
    Microsoft.Android.Runtime.NativeAOT.35.android-x64

Currently, the contents of all these packs are identical, but this is
an initial step to build multiple packs.

The plan is for the workload to only install the "Mono" packs, and the
"NativeAOT" packs can be restored via NuGet.
@jonathanpeppers
Copy link
Member Author

I think the main question here is if we are ok with the new naming scheme:

  • Microsoft.Android.Runtime.Mono.35.[RID]
  • Microsoft.Android.Runtime.NativeAOT.35.[RID]

Copy link
Member

@pjcollins pjcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach and names seem good to me here, we can always rename if we come up with something better later

@jonpryor jonpryor merged commit 38e8857 into main Nov 26, 2024
56 of 58 checks passed
@jonpryor jonpryor deleted the dev/peppers/runtime/flavors branch November 26, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants