-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #313: Remove config
dependency from handlers.
#315
Conversation
Signed-off-by: alexmerlin <[email protected]>
So now all routes that return a collection will have their own handler ? @alexmerlin |
Yes, all collection routes with their own handler that's sole purpose is to have a get method that returns the requested collection. This PR is not a final solution (unless accepted), but to me it looked to be the simplest and most straightforward one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side.
This implementation removes the dependency of
config
from all handlers.It also introduces new handlers for collection related endpoints.
@cPintiuta @MarioRadu let me know your thoughts, if this implementation solves the issue described in #313 or I should look into other solutions.