Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 259 #261

Merged
merged 7 commits into from
May 27, 2024
Merged

Issue 259 #261

merged 7 commits into from
May 27, 2024

Conversation

pinclau
Copy link
Member

@pinclau pinclau commented May 22, 2024

Initial commit of this issue is for review purpose, i need to make the tests for this

Copy link

github-actions bot commented May 22, 2024

Qodana for PHP

80 new problems were found

Inspection name Severity Problems
Undefined class 🔶 Warning 46
Undefined namespace 🔶 Warning 17
Undefined method 🔶 Warning 12
Incompatible return type 🔶 Warning 3
Type mismatch in property assignment 🔶 Warning 1
Property can be 'readonly' ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review covers only code/logic, no psalm/phpcs/readability related observations.
I will provide that level of review once the PR is in it's final stage.

src/App/src/Handler/NotFoundHandler.php Outdated Show resolved Hide resolved
src/App/src/Middleware/ContentNegociationMiddleware.php Outdated Show resolved Hide resolved
src/App/src/Middleware/ContentNegociationMiddleware.php Outdated Show resolved Hide resolved
src/App/src/Middleware/ContentNegociationMiddleware.php Outdated Show resolved Hide resolved
src/App/src/Middleware/ContentNegociationMiddleware.php Outdated Show resolved Hide resolved
src/App/src/Middleware/ContentNegociationMiddleware.php Outdated Show resolved Hide resolved
src/App/src/Middleware/ContentNegociationMiddleware.php Outdated Show resolved Hide resolved
src/App/src/Middleware/ContentNegociationMiddleware.php Outdated Show resolved Hide resolved
src/App/src/Middleware/ContentNegociationMiddleware.php Outdated Show resolved Hide resolved
@alexmerlin alexmerlin linked an issue May 23, 2024 that may be closed by this pull request
src/App/src/Middleware/ContentNegotiationMiddleware.php Outdated Show resolved Hide resolved
src/App/src/Middleware/ContentNegotiationMiddleware.php Outdated Show resolved Hide resolved
src/App/src/Middleware/ContentNegotiationMiddleware.php Outdated Show resolved Hide resolved
src/App/src/Middleware/ContentNegotiationMiddleware.php Outdated Show resolved Hide resolved
test/Unit/ContentNegotiationMiddlewareTest.php Outdated Show resolved Hide resolved
test/Unit/ContentNegotiationMiddlewareTest.php Outdated Show resolved Hide resolved
test/Unit/ContentNegotiationMiddlewareTest.php Outdated Show resolved Hide resolved
test/Unit/ContentNegotiationMiddlewareTest.php Outdated Show resolved Hide resolved
test/Unit/ContentNegotiationMiddlewareTest.php Outdated Show resolved Hide resolved
@alexmerlin
Copy link
Member

@MarioRadu add your review to this PR, in case that I missed something

@arhimede arhimede merged commit eeff618 into 4.0 May 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content negociation implementation
3 participants