Throw exception if in-memory database when running tests

[MarioRadu]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e5c0f1) 71.02% compared to head (9803c56) 71.02%.

Additional details and impacted files

@@            Coverage Diff            @@
##                4.0     #212   +/-   ##
=========================================
  Coverage     71.02%   71.02%           
  Complexity      652      652           
=========================================
  Files           109      109           
  Lines          2454     2454           
=========================================
  Hits           1743     1743           
  Misses          711      711           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alexmerlin]

The below is not a change request, just my insights on this case.

I would do something like this:

    /**
     * @throws NotFoundExceptionInterface
     * @throws ContainerExceptionInterface
     */
    public function setUp(): void
    {
        $this->enableTestMode();

        $this->initContainer();
        $this->initApp();
        $this->initPipeline();
        $this->initRoutes();

        $this->ensureTestMode();

        if (method_exists($this, 'runMigrations')) {
            $this->runMigrations();
        }
        if (method_exists($this, 'runSeeders')) {
            $this->runSeeders();
        }
    }

    /**
     * @throws ContainerExceptionInterface
     * @throws NotFoundExceptionInterface
     */
    protected function ensureTestMode(): void
    {
        if (! $this->isTestMode()) {
            throw new RuntimeException(
                'You are running tests, but test mode is NOT enabled. Did you forget to create local.test.php?'
            );
        }

        if (! $this->getEntityManager()->getConnection()->getParams()['memory'] ?? false) {
            throw new RuntimeException(
                'You are running tests in a non memory database. Did you forget to create local.test.php?'
            );
        }
    }

Note:

• I added ['memory'] ?? false because depending on the connection, the memory key might not be available (for example, with the real connection seems to return null)
• $this->getEntityManager()->getConnection()->getParams() is not a reliable solution because getParams is an internal method. Unfortunately the connection does not seem to offer a clean solution so another approach might be checking the config value under doctrine->connection->orm_default->params. The problem with this if there are somehow multiple connections used in a project, then we might look at the wrong config values (maybe it's not an actual issue, I'm just thinking out loud 😃 ).