-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [plugins/prometheus] allow to skip request or phases for a metric #3489
Open
EmrysMyrddin
wants to merge
12
commits into
main
Choose a base branch
from
feat/prometheus/skip-request
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+478
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6a615dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Benchmark Results
|
💻 Website PreviewThe latest changes are available as preview in: https://24244ce9.graphql-yoga.pages.dev |
Apollo Federation Subgraph Compatibility Results
Learn more: |
dotansimha
reviewed
Nov 12, 2024
dotansimha
approved these changes
Nov 13, 2024
EmrysMyrddin
force-pushed
the
feat/prometheus/skip-request
branch
from
November 22, 2024 10:22
e97d38f
to
eead95a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to explicitly control which events and timing should be observe.
This PR remove unnecessary hooks if possible, and adds the ability to skip the observation of a request.
This is an upstream Envelop feature.
On Yoga, selecting phases doesn't much sense. Perhaps we should add a "mandatory phases" in Envelop to handle those cases.
If it's also needed for the Mesh variant, we can introduce this additional concept, otherwise, we can just let it like this.