Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: links to current page don't work + undefined method `encode' for URI:Module #4

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: links to current page don't work + undefined method `encode' for URI:Module #4

wants to merge 4 commits into from

Conversation

Nawretard
Copy link

@Nawretard Nawretard commented May 1, 2024 •
edited
Loading

Description :

  • Change URI.decode/encode (deprecated on my Ruby version) to URI::Parser.new.escape/unescape
  • Fix bug where reference on a page to the page itself lead to file:///index.html instead of the page

Edit :
I changed a lot of things and some previous features I didn't know could be broken. If some code needs to be changed, please let me know.

this commit also fixes the issue #2

@Nawretard Nawretard mentioned this pull request May 3, 2024
Open
@Nawretard Nawretard changed the title fix: self references lead to the file:///index.html instead of self, small code refactoring to reduce complexity fix: links to current page don't work + undefined method `encode' for URI:Module May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nawretard