Allow classname in 'value' attribute of xml discriminator-mapping field #11450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure how I forgot these.
Narrow down parameter types for quote strategies
ClassMetadata->$fetch
This must have been lost when merging up d7d6b9d
Declare options property
It does not seem to ever be empty
Make the join table name and join column name mandatory
Migrate to the object API of Join{Column,Table}Mapping
The linked issue has been addressed, this rules should have been removed during a merge up, as it is no longer present on 2.x
That property has been removed from 3.0.x
Note that we also remove UpdateCommandTest::testItPrintsTheSql() because it relied on not passing --complete to work.
Cleanup bc layers
Avoid another occurrence of ArrayAccess
Merge 2.19.x up into 3.1.x
To reduce Algolia operations and indexes older versions get removed
Fixed proxy initialization for EnumReflectionProperty
* 2.19.x: Set column length explicitly (#11393) Add missing import Remove unused variable (#11391) [Documentation] Removing "Doctrine Mapping Types" ... (#11384) [GH-11185] Bugfix: do not use collection batch loading for indexBy assocations. (#11380) Improve lazy ghost performance by avoiding self-referencing closure. (#11376)
SchemaValidator: Changing mapping of BIGINT to string|int
Fix fromMappingArray definition
docs: update PHP version in doc
* 2.19.x: Fix BIGINT validation (#11414) Fix templated phpdoc return type (#11407) [Documentation] Merging "Query Result Formats" with "Hydration Modes" Fix psalm errors: remove override of template type Update dql-doctrine-query-language.rst Adding `NonUniqueResultException` [Documentation] Query Result Formats
Merge 3.0.x up into 3.1.x
Targeting 2.19.x, since we want the updates to bubble up. Since Dependabot has had no effect on doctrine/dbal yet, I suppose that means that "dependabot.yml" must be present on the default branch.
Setup Dependabot
It will handle caching for us.
|
According to #11208, you're probably not targeting the right branch. |
|
Closing to start from the correct branch |
|
@MatteoFeltrin it is possible to retarget a PR with the edit button. |
|
@greg0ire sorry for my ignorance, it was the first time contributing to an upstream repository, I forked with only with 3.1.x branch and didn't know how to add the correct one, so preferred to do it from scratch 😅 |
|
No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11449
In relation to #10630
This PR allows a more loosen validation of the
valueattribute ofdiscriminator-mappingfield, usingorm:typein the XSD schema as it was done in the linked pull request.The test I written loads the entity enabling the validation against XSD schema, thus expects no exception to be thrown.