Modernize codebase for PHP 8 #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/php-8
branch
2 times, most recently
from
f2ac883
to
39171dd
Compare
stof
reviewed
Aug 18, 2023
| @@ -35,7 +35,7 @@ public function getConfiguration(): Configuration | |||
|
|
|||
| try { | |||
| $config = Yaml::parse($content); | |||
| } catch (ParseException $e) { | |||
| } catch (ParseException) { | |||
There was a problem hiding this comment.
shouldn't we rather attach it as a previous exception, so that the user can see the actual parsing issue ?
There was a problem hiding this comment.
Yes, but that's out if scope for this PR. We can do this in a follow-up.
derrabus
force-pushed
the
improvement/php-8
branch
4 times, most recently
from
141a298
to
5be5221
Compare
|
BC check failure:
I think those changes are safe. We've only ever accepted those types anyway and existing child classes that override this method without parameter types should continue to work. |
greg0ire
approved these changes
Aug 19, 2023
SenseException
approved these changes
Aug 19, 2023
derrabus
force-pushed
the
improvement/php-8
branch
from
5be5221
to
94e8016
Compare
derrabus
added a commit
to derrabus/migrations
that referenced
this pull request
Sep 7, 2023
* 3.7.x: (21 commits) Allow doctrine/deprecations 1.0 (doctrine#1358) Drop support for Symfony 4 (doctrine#1352) Modernize codebase for PHP 8 (doctrine#1351) Remove docs from the archives (doctrine#1356) Ditch action in favor of running tool directly (doctrine#1354) Fix PHPStan errors after PHPUnit update (doctrine#1350) Add sh to .gitattributes Update .gitattributes Avoid complex mock building Migrate to PHPUnit 10 Make data providers static Remove unneeded phpcs rule Suffix abstract test class with TestCase Add details to sync-metadata-storage's help Update coding standard to v12 Remove ignore rule for @method-provided method build: Use the new compactors build: Fix cleanup of the backup composer lock file Add attributes to commands removed preceding whitespace in front of colons ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We require PHP 8.1 already, so let's use what PHP 8 has to offer for us.