Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCKA-2517 Check for existing revocation registry before creating a new one. #22

Merged
merged 2 commits into from
Apr 22, 2024
Merged

DCKA-2517 Check for existing revocation registry before creating a new one. #22

merged 2 commits into from
Apr 22, 2024

Conversation

gasher
Copy link
Collaborator

@gasher gasher commented Apr 17, 2024 •
edited
Loading

This PR should be tested/merged only after this PR is deployed

@gasher gasher self-assigned this Apr 17, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dock-bank-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 11:44am

@gasher gasher changed the title Check for existing revocation registry before creating a new one. DCKA-2517 Check for existing revocation registry before creating a new one. Apr 17, 2024
cykoder
cykoder reviewed Apr 18, 2024
View reviewed changes
utils/dock-registries.js Outdated Show resolved Hide resolved
cykoder
cykoder requested changes Apr 18, 2024
View reviewed changes
Copy link
Member

@cykoder cykoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change to add a limit, will make it slightly faster in worst scenarios. i do wonder if we can just get a registry ID as an env variable or something though as that'll be quicker than searching for one. this may do for now though

@gasher gasher requested a review from cykoder April 18, 2024 11:43
@cykoder cykoder merged commit 156f378 into main Apr 22, 2024
3 checks passed
@cykoder cykoder deleted the DCKA-2517-Sales-demo-should-not-create-new-revocation-registry-for-each-issuance branch April 22, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-parkhill mike-parkhill mike-parkhill approved these changes

@cykoder cykoder cykoder approved these changes

Assignees

@gasher gasher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gasher @cykoder @mike-parkhill