Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bake: switch to controller #1861

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

bake: switch to controller #1861

wants to merge 5 commits into from

Commits on Jun 6, 2023

  1. controller: refactor build inputs to external struct 

    This patch continues the move to attempt to merge the build.Options
struct into the controllerapi.Options message.

To do this, we extract all the input parameters into a dedicated message
(adding the missing ones, except for the InStream parameter which will
require some additional fiddling around). We also rework the
NamedContexts to allow containing States (by transmitting them as
DefinitionOps), and adding a Linked field to the common options.

Signed-off-by: CrazyMax <[email protected]>
    @jedevc @crazy-max
    jedevc authored and crazy-max committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    3c3e4a6 View commit details
    Browse the repository at this point in the history

  2. bake: use controller build options as an intermediate stage 

    With the previous changes to bring controllerapi.BuildOptions up to date
with build.Options, we can have bake generate
controllerapi.BuildOptions, and then convert those to build.Option using
the controller/build package.

This is an intermediate patch, designed to allow us to clean up some
shared logic between both build and bake. The next step will be to
modify bake to use the controller api, and completely skip the
build.Options generation step.

Signed-off-by: CrazyMax <[email protected]>
    @jedevc @crazy-max
    jedevc authored and crazy-max committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    9387640 View commit details
    Browse the repository at this point in the history

  3. bake: use controller to build 

    With this change we are now passing a list of controller options
to run a build and returns a map of responses and result context
as bake can handle a list of targets.

Signed-off-by: CrazyMax <[email protected]>
    @crazy-max
    crazy-max committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    9df1970 View commit details
    Browse the repository at this point in the history

  4. controller: remove MetadataFile from CommonOptions 

    Signed-off-by: CrazyMax <[email protected]>
    @crazy-max
    crazy-max committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    73b4e04 View commit details
    Browse the repository at this point in the history

  5. build: mark result handle build as internal 

    Signed-off-by: CrazyMax <[email protected]>
    @crazy-max
    crazy-max committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    e16151f View commit details
    Browse the repository at this point in the history