fix: adjust ExpandedHelpHeight to prevent screen corruption #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resolve: #384
In PR #366, the layout of the items displayed in the full help view in the PRs screen was changed. As a result, the height of the help view was altered.
This caused the height of the help view to differ from the expected value, leading to layout corruption when toggling the help view.
To address this issue, I have adjusted the height to match the current actual height of the help view.
How did you test this change?
I manually tested the change and confirmed that the help view is now displaying correctly.
Images/Videos
gh-dash-pr03.mp4