add wtrlab multilingual source #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2222
Closes #1437
Tested search and download manually, seems to work just fine.
Basically the same as #2239 as they use the same framework (nextjs, angular or something like that, not sure...)
I am looking into maybe adding a new template so these could be added more easily but there are some strong differences in URLs, JSON Keys and URLs in general for both websites so I'm not sure how viable that actually is.
A lot can also be read out of the json itself as it has the templates for URIs in some cases I believe but that's not necessarily a given at all times so it's pretty opaque at the moment.