Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

novel-bin.net #2139

Merged
merged 1 commit into from
Sep 26, 2023
Merged

novel-bin.net #2139

merged 1 commit into from
Sep 26, 2023

Conversation

SirGryphin
Copy link
Contributor

@SirGryphin SirGryphin commented Sep 21, 2023

Note: Did do another pull request but closed it because I getting checking error. I thought maybe I used older dev version and forgot to update so I update and create source file again it still fails on something to do with telegram which I haven't touched.

Added source for another version of novelbin sites. Created a file as I needed to use Rate limit because of too many request error.

Also @dipu-bd I'm not sure if you want to combined certain novelbin sources, I know if there same site you just add alternative domains to the base_url.

It just it noticed the following sources:
novelbin.py = https://novelbin.com/
novelbin.net.py = https://novelbin.net/
novel-bin.py =https://novel-bin.com/

and my one
novel-bin.net.py = https://novel-bin.net/

I think there all the same site, I'm not 100% sure though could be different, I know novel-bin.net had the novel I need and none of the other did so it could just be using same name and site template, it's also another reason I created separate source.

@jere344
Copy link
Contributor

jere344 commented Sep 23, 2023

@dipu-bd
Copy link
Owner

dipu-bd commented Sep 26, 2023

If they can be parsed with the same code, they can be combined together. Otherweise we should make separate crawlers.

@dipu-bd dipu-bd merged commit 13a0f4a into dipu-bd:dev Sep 26, 2023
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants