Fix asset_lint job #122
Merged
Fix asset_lint job #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
commented
Jan 11, 2024
| @@ -186,6 +186,11 @@ jobs: | |||
| uses: "actions/setup-node@v3" | |||
| with: | |||
| node-version: "${{ matrix.node }}" | |||
| - run: | | |||
| npm install | |||
| gsnpm run lint | |||
There was a problem hiding this comment.
There is no "gsnpm" command.
szepeviktor
commented
Jan 11, 2024
|
|
||
| - name: "Install dependencies" | ||
| run: | | ||
| npm ci |
There was a problem hiding this comment.
"ci" (clean install) does not modify the lock file.
szepeviktor
commented
Jan 11, 2024
Comment on lines
+194
to
+196
| - name: "Run checks" | ||
| run: | | ||
| npm run lint |
There was a problem hiding this comment.
Let's have each step separately.
|
|
|
Thanks for the fixes. I've changed the branch to |
|
Done 🍏 |
dingo-d
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dingo-d