Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a fixed version for checkout action #838

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

hanefi
Copy link
Contributor

@hanefi hanefi commented Jul 8, 2024

This PR fixes our stylechecker tests using the following changes:

  • Updated stylechecker image to a new version with updated packages
  • Set a fixed version of checkout action
    to not get affected by later releases
  • Set safe directory for git repository to fix a new set of errors I got during my tests

- Update stylechecker image to a new version
- Set a fixed version of checkout action
- Set safe directory for git repository
@@ -60,9 +60,14 @@ jobs:

style_checker:
runs-on: ubuntu-latest
container: citus/stylechecker:latest
container: citus/stylechecker:no-py
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to rebuild the docker image, but failed as some of the python package versions in the container no longer is available in Python Package Index. I ended up removing all of those broken dependencies in citusdata/the-process#156 to create a new docker image that has working citus_indent tool.

@hanefi hanefi marked this pull request as ready for review July 9, 2024 17:38
@hanefi hanefi changed the title Use latest major for checkout action Use a fixed version for checkout action Jul 9, 2024
@dimitri dimitri merged commit 6df9bae into dimitri:main Jul 9, 2024
19 checks passed
@hanefi hanefi deleted the fix-checkout-action branch July 10, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants