corrupted ccz handling #779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knguyen142
commented
Oct 28, 2020
| @Override | ||
| public String removeArchiveFile(String appId) { | ||
| String mGUID = super.removeArchiveFile(appId); | ||
| redisTemplate.delete(String.format("formplayer:archive:%s", mGUID)); |
There was a problem hiding this comment.
Look into deleting the file on disk.
|
@knguyen142 One weakness in this caching code that I found a while ago is that it appears to re-use the same redis cache key across all of the servers despite the file being local #741. One downside to this is that removing the key does remove the key for every other server as well, which may or may not be worth worrying about. I'm not actually sure the redis keyed cache does very much (since it kind of can't) v. the in-memory cache. |
knguyen142
force-pushed
the
kev/corrupted-ccz-fix
branch
from
c6e106a
to
617de50
Compare
|
I decided to close this because we cannot reproduce the underlying issue, so these changes might end up doing more harm than good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dimagi-dev.atlassian.net/browse/SAAS-11333
If the downloaded ccz is corrupted, we still save it in memory and continually hit the same exception.
This handles it so that if we hit those exceptions, we clear the ccz from memory so subsequent requests will try to redownload.
Testing
Tested locally.
x).
3. Fix the cchq code so we return the actual contents 4. retry webapps, and it successfully downloads and runsIssues
This can download a lot of ccz's if cchq continually returns invalid files
I don't know if all paths to those exceptions should have the ziparchive file be removed from memory. I also couldn't test the
UnresolvedResourceExceptionexception path, which is what was the original exception in the issue.Depends on
https://github.com/dimagi/commcare-core/pull/943, do not merge until that is in this PR.