Add Rules field to create Databases with Firewall Rules #758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Create a New Database Cluster I've noticed the
rules
field was missing.I've added this field to the
DatabaseCreateRequest
struct. And a newDatabaseCreateFirewallRule
struct.I didn't use the already existing
DatabaseFirewallRule
because of the following:CreatedAt
field is not present in the API Create Request. Only when you get the list of firewall rules for a Database.ClusterUUID
field in the documentation seems to be a bug. This field is ignored when creating a Database / doesn't make sense to be present. The Database Cluster ID is the same ID the database will have after being created.Also I've added a test which creates a Database with two firewall rules.