Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-line inline code styling #106

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

MattIPv4
Copy link
Contributor

Type of Change

  • SCSS Styling: Code/links

What issue does this relate to?

cc #103

What should this PR do?

While #103 did fix the more prevalent issue of inline code in links becoming unreadable when hovered, that fix ended up breaking the less common situation of inline code spanning across a linebreak (due to the background now being a pseudo-element rather than an actual background).

To fix this, I've partially reverted the change the previous PR made, sticking to using just a regular old background for inline code, and have then changed how inline code inside a link gets styled to use multiple background layers to combine the link treatment with the inline code background seamlessly.

What are the acceptance criteria?

  • Inline code, including across linebreaks, has a background
  • Inline code, inside a link, including across linebreaks, has a background
  • Regular text, inside a link, including across linebreaks, has a background

I have been using this snippet to test:

`this is a really long bit of inline code. this is a really long bit of inline code. this is a really long bit of inline code. this is a really long bit of inline code. this is a really long bit of inline code. this is a really long bit of inline code. this is a really long bit of inline code. this is a really long bit of inline code.` this is not inline code

[`this is a really long bit of inline code. this is a really long bit of inline code. this is a really long bit of inline code. this is a really long bit of inline code. this is a really long bit of inline code. this is a really long bit of inline code. this is a really long bit of inline code. this is a really long bit of inline code.` this is not inline code]()
image image

@MattIPv4 MattIPv4 added bug Something isn't working patch Change is SEMVER patch labels Apr 26, 2024
dbadea-heits
dbadea-heits previously approved these changes Apr 26, 2024
@MattIPv4 MattIPv4 merged commit b59f604 into master Apr 29, 2024
5 checks passed
@MattIPv4 MattIPv4 deleted the MattIPv4/fix-inline-code-multi-line branch April 29, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Change is SEMVER patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants