Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Diamond performance optimization #352

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

stas-kh
Copy link
Collaborator

@stas-kh stas-kh commented Jun 12, 2023

What's been done:

  1. Getting rid of redundant packages, CSS files, depenedencies
  2. Adding webpack-bundle-analyzer
  3. Optimizing lodash imports
  4. Moving <app-page> outside of the router-outlet to reduce code duplications
  5. Getting rid of unused components
  6. Introducing sizes on simple-center-loader and making it CSS only (prevents sticking of the loader when feed is loading)
  7. Removing bootstrap date picker in favor of pure HTML one
  8. Getting rid of sprintf function and using built-in string literals
  9. Making blog posts a separate lazy-loaded module
  10. Importing quill-mention on demand to reduce final bundle size
  11. Refactored some of imports (using relative path like ../../path instead of src/app/path-to-file)
  12. Fixing most of production build warnings

Screenshots:

Lighthouse report on the most highly loaded content (feed) before optimization
Screenshot 2023-06-12 at 14 17 49

Lighthouse report on the most highly loaded content (feed) after optimization
Screenshot 2023-06-12 at 14 15 31

Webpack bundle analyzer comparison (vendor size is 1.5Mb smaller now, + blog posts is a separate module)
Screenshot 2023-06-12 at 14 26 21

Production build + gzipped (latest numbers):
Screenshot 2023-06-12 at 14 27 34

@stas-kh stas-kh force-pushed the chore/diamond-optimization branch from d57a670 to ff0c75a Compare June 12, 2023 10:50
@stas-kh stas-kh marked this pull request as ready for review June 15, 2023 08:33
@stas-kh stas-kh requested a review from superzordon June 15, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants