test: simplify metadata assertions DHIS2-14968 #19347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I initially though I would need to also assert on nested relationship objects. This is why I tried to make generic assertions that could be reused for fields like dataValues on the event and on a relationships event. Since we do not need that make the assertions less complicated.
teleivo
force-pushed
the
DHIS2-14968-test
branch
from
6b95c9d
to
6b7bd7c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially though I would need to also assert on nested relationship objects. This is why I tried to make generic assertions that could be reused for fields like dataValues on the event and on a relationships event. Since we do not need that make the assertions less complicated.