chore: let COC.isDefault look at its own name only DHIS2-14968

[teleivo]

discovered while implementing #19252

Category option combos are not always fetched using hibernate. In tracker we use jdbc when fetching events and only fetch and map what's needed. We thus do not get the category combo. This means that coc.isDefault() returns false even if it is the default coc.

We want to change isDefault

  @Override
  public boolean isDefault() {
-    return categoryCombo != null && DEFAULT_NAME.equals(categoryCombo.getName());
+    DEFAULT_NAME.equals(name);
  }

Default category/option/combo are created on startup

dhis2-core/dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/category/DefaultCategoryService.java

Line 378 in 916f741

return getCategoryComboByName(CategoryCombo.DEFAULT_CATEGORY_COMBO_NAME);

The category option name is unique and the system "takes" the default name. The coc is generated from the co and so is its name which is default.

When retrieving the default coc from the service it already relies on the name default

dhis2-core/dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/category/DefaultCategoryService.java

Lines 582 to 584 in 916f741

	public CategoryOptionCombo getDefaultCategoryOptionCombo() {
	return categoryOptionComboStore.getByName(CategoryCombo.DEFAULT_CATEGORY_COMBO_NAME);
	}

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jbee]

As Jim mentioned there is code using the wrong constant for the string "default" because they all are the same but good that you cleaned that up as well. It is a bit confusing and I assume was just a copy&paste or autocomplete mistake made in the past.

[jason-p-pickering]

Hmm. Is this the only way to solve this problem? I see that all of the tests pass, but I do worry about changing this for this particular reason. What happens when there are multiple default COCs? I have been working on a PR here to prevent import of new/duplicate COCs, and we have some integrity checks around this as well, but we do know of systems which either have a default CC/CO/COC which are not the hard-coded ones which we currently have, or which have actual duplicate default COCs (i.e multiple "default" COCs) which are associated with the default CC.