fix: persist update to personal access token [DHIS2-17382] #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomzemp
commented
Sep 10, 2024
| @@ -29,6 +29,7 @@ const getJsonPatch = ({ formattedValues, form, requestsTouched }) => { | |||
| const targetFields = [ | |||
| 'type', | |||
| 'authentication', | |||
| 'accessToken', | |||
There was a problem hiding this comment.
this is the actual change outside of the addition of the automated test.
|
🚀 Deployed on https://pr-101--dhis2-data-exchange.netlify.app |
Birkbjo
approved these changes
Sep 10, 2024
dhis2-bot
added a commit
that referenced
this pull request
Sep 11, 2024
## [100.9.5](v100.9.4...v100.9.5) (2024-09-11) ### Bug Fixes * persist update to personal access token [DHIS2-17382] ([#101](#101)) ([db25fa4](db25fa4))
|
🎉 This PR is included in version 100.9.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://dhis2.atlassian.net/browse/DHIS2-17382
accessTokenwas missing from fields checked to persist update.Before: updating access token did not trigger patch to update.
After: updating access token triggers patch update.
Tested manually and added an automated test.