Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to merge rootstock changes on 2019-03-14 #5

Merged
merged 257 commits into from
Mar 14, 2019
Merged

Conversation

dhimmel
Copy link
Owner

@dhimmel dhimmel commented Mar 14, 2019

Since this repo used a squash method to clone rootstock as discussed in manubot/rootstock#65, merging rootstock changes is a bit more difficult.

I used the following workflow for this PR:

git checkout -b rootstock-`date '+%Y-%m-%d'`
git pull --allow-unrelated-histories --no-ff --no-commit rootstock master
# For files where we only want the version created in our instance (e.g. ci/deploy.key.enc)
git checkout --ours FILE_PATH
# For files that our instance has never modified
git checkout --theirs FILE_PATH
# For other files where both our instance and rootstock have content we want to preserve, resolve conflicts in text editor.
# Add all files and commit
# Open pull request

cgreene and others added 30 commits August 5, 2016 10:36
Add in stub files so that we can start writing.
Start to stub in categorize section
* Enable tag citations

See greenelab/deep-review#2 (comment).

* Reflow text to satisfy codeclimate
dhimmel and others added 19 commits December 11, 2018 11:06
Merges manubot/rootstock#150

Attempt to upgrade preexisting timestamps during continuous
deployment, such that manually upgrading incomplete timestamps
should no longer be necessary.

Add two mutually exclusive arguments to webpage.py:
--ots-cache and --no-ots-cache for configuring the OTS client
caching.

Disable timestamp caching for deploy.sh (i.e. on Travis CI)
Merges manubot/rootstock#151

* Upgrade manubot python package with Wikidata citations
* Remove DataCite DOI from 02.delete-me.md
* Add additional manuscripts to USAGE examples
Merges manubot/rootstock#159

When printing, hide hypothesis toolbar and fix page margins.

Fix pandoc syntax highlighting quirk: long width code boxes
overflow outside of container.

Fix superscript size issue documented at
greenelab/meta-review#88 (comment)
Merges manubot/rootstock#166

Improves formatting and centering of icons.
Uses github and twitter icons from https://fontawesome.com
Merges manubot/rootstock#172

Fixes issue that fill="currentColor" did not work as expected because SVGs
are loaded from URLs rather than defined inline. Hence, revert to specifying
a specific color.
Merges manubot/rootstock#171

Various display improvements, simplified code structure with modern
best practices.
Merges manubot/rootstock#174

* Environment update on 2019-02-06

Does not upgrade weasyprint or cairo, due to the following error during
WeasyPrint execution:
OSError: dlopen() failed to load a library: cairo / cairo-2 / cairo-gobject-2

Specify cairocffi dependency in environment.yml, since v0.9 from PyPI
seemed to trigger the OSError.

* Add shortDOI support & usage

Update repo to https://github.com/manubot/manubot
greenelab/manubot relocated to manubot/manubot as per
manubot/manubot#94.

02.delete-me.md still references greenelab/manubot,
however it is not worth creating merge conflicts to
update just this.
Merges manubot/rootstock#182

Update SETUP.md to replace the correct random string

Fix missing x86_64-conda_cos6-linux-gnu-gcc in psutil install by installing
psutil using conda.

.travis.yml: one configuration option per line (non-functional whitespace change)
Merges manubot/rootstock#184

Previously, ci/deploy.sh could be run for push, api, or cron builds,
but not for pull_request builds. This commit further restricts when
deployment is run to just push builds.
Merges manubot/rootstock#178

Various aesthetic updates, refactoring, edits for plugins, and additional comments
Merges manubot/rootstock#179
Closes manubot/rootstock#185
Improves manubot/rootstock#165

Adds plugins that can be included in the pandoc build commands
to enable various interactive frontend features. Plugins are located in
`build/plugins/` and consist of:

- accordion (new)
- analytics (modified)
- anchors (replaced)
- hypothesis (modified)
- jump-to-first (new)
- lightbox (new)
- link-highlight (new)
- math (modifies how MathJax is loaded)
- table-of-contents (new)
- table-scroll (new)
- tooltips (new)
Merges manubot/rootstock#188

Miscellaneous changes to default.html style including background colors,
text/page alignment classes, print control styles.

Switch margins to 0.75 inches to reduce pages needed to print manuscript.
Used code like:

```
git checkout -b rootstock-`date '+%Y-%m-%d'`
git pull --allow-unrelated-histories --no-ff --no-commit rootstock master
git checkout --ours FILE_PATH
git checkout --theirs FILE_PATH
```
@dhimmel
Copy link
Owner Author

dhimmel commented Mar 14, 2019

Build of d750725 has passed, so I will go ahead and squash merge.

@dhimmel dhimmel merged commit 1ddd48d into master Mar 14, 2019
@dhimmel dhimmel deleted the rootstock-2019-03-14 branch March 14, 2019 15:36
@dhimmel
Copy link
Owner Author

dhimmel commented Mar 14, 2019

Deployedment of the merged squashed commit (1ddd48d) failed according to the build log:

test $TRAVIS_BRANCH = "master" && test $TRAVIS_EVENT_TYPE = "push" && sh ci/deploy.sh
Switched to branch 'master'
M	webpage/README.md
Your branch is up to date with 'origin/master'.
Agent pid 5354
Identity added: ci/deploy.key (ci/deploy.key)
Warning: Permanently added the RSA host key for IP address '192.30.253.112' to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

dhimmel added a commit that referenced this pull request Mar 14, 2019
This build is based on
1ddd48d.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/dhimmel/rephetio-manuscript/builds/506344659
https://travis-ci.org/dhimmel/rephetio-manuscript/jobs/506344668

[ci skip]

The full commit message that triggered this build is copied below:

PR to merge rootstock changes on 2019-03-14

Merges #5
dhimmel added a commit that referenced this pull request Mar 14, 2019
This build is based on
1ddd48d.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/dhimmel/rephetio-manuscript/builds/506344659
https://travis-ci.org/dhimmel/rephetio-manuscript/jobs/506344668

[ci skip]

The full commit message that triggered this build is copied below:

PR to merge rootstock changes on 2019-03-14

Merges #5
@dhimmel
Copy link
Owner Author

dhimmel commented Mar 14, 2019

According to https://github.com/dhimmel/rephetio-manuscript/settings/keys there are no deploy keys... that could explain the issue. Added the public key with write as a deploy key on github and restarted the build.

dhimmel added a commit that referenced this pull request Nov 20, 2019
Using method described in #5 (comment)
dhimmel added a commit that referenced this pull request Nov 20, 2019
merges #8

updates rootstock to manubot/rootstock@277a769

used squash method for updating described at #5 (comment)
dhimmel added a commit that referenced this pull request Nov 20, 2019
This build is based on
d020443.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/dhimmel/rephetio-manuscript/builds/614673307
https://travis-ci.org/dhimmel/rephetio-manuscript/jobs/614673308

The full commit message that triggered this build is copied below:

Update rootstock on 2019-11-20 (#8)

merges #8

updates rootstock to manubot/rootstock@277a769

used squash method for updating described at #5 (comment)
dhimmel added a commit that referenced this pull request Nov 20, 2019
This build is based on
d020443.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/dhimmel/rephetio-manuscript/builds/614673307
https://travis-ci.org/dhimmel/rephetio-manuscript/jobs/614673308

The full commit message that triggered this build is copied below:

Update rootstock on 2019-11-20 (#8)

merges #8

updates rootstock to manubot/rootstock@277a769

used squash method for updating described at #5 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.