Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Docker container as unprivileged user, allow PUID/PGID selection #722

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Run Docker container as unprivileged user, allow PUID/PGID selection #722

wants to merge 14 commits into from

Commits on Nov 8, 2024

  1. Run Docker container as unprivileged user 

    Previously, the container process ran with root privileges.
This commit changes the default to an unprivileged user and
makes it possible to specify PUID/PGID environment variables
to choose UID/GID.
Migration of existing data owned by root is handled transparently.
    @lkubb
    lkubb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    12d26c6 View commit details
    Browse the repository at this point in the history

  2. Improve docker entrypoint to work rootless 

    * The previous behavior required root privileges on start, now this is
optional (when run in rootless mode with --user). The user has to ensure
the correct ownership is set for existing data in that case.

* Furthermore, it is now possible to choose to keep root privileges by
setting KEEP_PRIVILEGES to something non-empty.

* This also renames abc user to changedetection (nicer).
    @lkubb
    lkubb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    a48b75d View commit details
    Browse the repository at this point in the history

  3. Use variable for datastore in Docker entrypoint

    @lkubb
    lkubb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    10cc499 View commit details
    Browse the repository at this point in the history

  4. Correct semantics on KEEP_PRIVILEGES in Docker entrypoint

    @lkubb
    lkubb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    f706603 View commit details
    Browse the repository at this point in the history

  5. Create test datastore for pytest to run in

    @lkubb
    lkubb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    1d120a1 View commit details
    Browse the repository at this point in the history

  6. Correct mode on entrypoint script

    @lkubb
    lkubb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    5d19c9c View commit details
    Browse the repository at this point in the history

  7. Do not write bytecode in Docker container

    @lkubb
    lkubb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    d6966d8 View commit details
    Browse the repository at this point in the history

  8. Fix datastore path handling

    @lkubb
    lkubb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e37e3d7 View commit details
    Browse the repository at this point in the history

  9. Use COPY --chmod

    @lkubb
    lkubb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    0bd4a8e View commit details
    Browse the repository at this point in the history

  10. Don't write to the app directory in tests

    @lkubb
    lkubb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    467315d View commit details
    Browse the repository at this point in the history

  11. Don't create Pytest cache in container by default

    @lkubb
    lkubb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    9ca18ff View commit details
    Browse the repository at this point in the history

  12. Ensure changedetection has a home dir 

    ... to be able to install extra packages via pip
    @lkubb
    lkubb committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    0f425e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. Don't force the DATASTORE_PATH 

    This got lost during a rebase, it's not necessary anymore since the env
var is set inside the container by default and changedetection respects it.
    @lkubb
    lkubb committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    a1285f2 View commit details
    Browse the repository at this point in the history

  2. Only chown if datastore is not writable by PUID:PGID

    @lkubb
    lkubb committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    89c9ead View commit details
    Browse the repository at this point in the history