Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store each watch config in its own directory, saves rewriting the whole json file each time #2605

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dgtlmoon
Copy link
Owner

@dgtlmoon dgtlmoon commented Sep 4, 2024

todo

  • use a checksum or string comparison lookup of the watch dicts to know if they should be updated
  • move the file/IO stuff out of 'store.py' into 'storage.py' perhaps, so it could be used with other systems? (other document storage backends)

Advantages

  • Lower memory usage when using json.dumps
  • MUCH lower disk-io
  • In the future a command-line can be run against just a single watch config
  • Easily import and/or copy configs from somewhere else, just dump them into the datastore directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant