Preserve order of items in maps #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TOML format has a restriction that if a table itself contains tables, all keys with non-table values must be emitted first. This commit enforces said order by modifying value::Values recursively before handing them to the TOML serializer.
toml 0.6 is based on toml_edit, it: - allows to preserve order - fixes some mis-serializaitons, e.g. with mixed lists - does not require order of non-/table values in maps This reverts the previous commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minus one TODO. My first impulse was to reach for indexmap, but
Value::Mapis never actually accessed by key.